I like swords and am good with them.
Spears are quite possibly superior, and certainly deserve more historical credit. It's a bit like the Hurricane and Spitfire that way. The Hurricane did the majority of the work but most of the films are about the flashier Spitfire.
The quarterstaff is not a weapon I know how to use well, but it'd be a good one to learn because the garden centre sells them (under the Fenceposts brand name) so in the unlikely event of me having to grab a weapon and rush to the aid of some Hapless Citizen being assaulted at the supermarket, they'd be right there for me. Also they're ****** hard to get past with a sword.
I like rifles and am good with them. They have their uses in hunting for food and vermin control.
I am some good with automatic pistols. They're useful in short-range and/or confined-space fighting where speed and mobility matter more than accuracy and they're portable.
I can reliably hit a barn from the inside with a revolver. They're reliable machines and easy to learn to use.
Knives are really good for skinning and cleaning deer and rabbits, and for silent take-downs from behind, but they're not a weapon with which I'd fight. In a knife-fight, both of you wind up in hospital, and maybe one goes to intensive care but at least one goes to the morgue.
I'm in England. We can legally carry a profane vocabulary but we can get in trouble for using it. Actually, we can have shotguns, rifles, bows, crossbows, swords, spears, knives, axes, maces and even some pistols, but it's not Alabama. Considering we're a bit smaller than Manitoba or Alberta and have a population going on 70 million, we're a long way from Texas, too. There just aren't that many places you can lose a rifle bullet without significant risk of ruining someone's evening. We can have "silencers" / moderators / noise attenuators / muzzle brakes / recoil compensators and so on. Keeping it accurate is always good and keeping it quiet is both sensible from a vermin-stalking point of view and, crucialy to Britons, polite.